Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): update obsolete lambda runtime #5379

Merged

Conversation

jonathanbro
Copy link
Contributor

Context

Please include relevant motivation and context for this PR.

Adding additional lambda runtimes to check for in AWS.

https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html#runtimes-deprecated

Description

No fix, just providing more criteria to check.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathanbro jonathanbro requested review from a team as code owners October 11, 2024 11:14
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @jonathanbro ! Please, review my comment.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (03a26ec) to head (3c2bb21).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5379      +/-   ##
==========================================
+ Coverage   89.38%   89.41%   +0.02%     
==========================================
  Files        1022     1023       +1     
  Lines       31416    31434      +18     
==========================================
+ Hits        28081    28106      +25     
+ Misses       3335     3328       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
@jonathanbro
Copy link
Contributor Author

I've committed your suggestion @sergargar :)

@sergargar sergargar self-requested a review October 11, 2024 15:40
@sergargar sergargar merged commit 444d820 into prowler-cloud:master Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants