Bump github.com/cometbft/cometbft to v0.38.10 (from 0.38.10-pio-1). #2097
Conversation
WalkthroughThe recent updates primarily focus on dependency upgrades and configuration changes. The notable updates include bumping the version of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (2 hunks)
Files skipped from review due to trivial changes (1)
- go.mod
Additional context used
Markdownlint
CHANGELOG.md
46-46: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Additional comments not posted (1)
CHANGELOG.md (1)
46-46: Update on Dependency Version in ChangelogThe changelog correctly documents the update of the
github.com/cometbft/cometbftdependency from versionv0.38.10-pio-1tov0.38.10. This aligns with the summary provided, ensuring the changelog is accurate and up-to-date.Tools
Markdownlint
46-46: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
…r in it that just changed.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cmd/provenanced/cmd/config_test.go (1 hunks)
Additional comments not posted (4)
cmd/provenanced/cmd/config_test.go (4)
Line range hint
36-68: Review of SetupTest Function:The
SetupTestfunction properly sets up the test environment by configuring directories, logging, and default settings. It uses safe practices for directory creation (s.T().TempDir()) and disables address caching which is a good practice for isolated test cases.However, consider handling potential errors from
pioconfig.SetProvenanceConfigandprovconfig.DefaultKeyringBackendto ensure that the test setup does not proceed with misconfigured settings.
Line range hint
97-103: Review of getConfigCmd Function:The
getConfigCmdfunction correctly initializes the configuration command and ensures that the configuration is loaded from files without errors. This is crucial for ensuring that subsequent tests run with the expected setup.Consider adding more detailed error handling or logging within
provconfig.LoadConfigFromFilesto provide clearer diagnostics in case of configuration load failures.
Line range hint
319-341: Review of TestConfigBadArgs Function:The
TestConfigBadArgsfunction effectively tests various error scenarios for configuration commands, ensuring that the system behaves as expected under erroneous conditions. Each test case is clearly defined and asserts specific error messages, which is good for maintainability and understanding test coverage.Consider adding a few more edge cases if applicable, such as testing with excessively long strings or special characters to further ensure the robustness of the command parsing.
Line range hint
497-526: Review of TestConfigSetValidation Function:The
TestConfigSetValidationfunction thoroughly tests the validation mechanisms for different configuration settings. It ensures that invalid settings are correctly identified and rejected, which is crucial for maintaining system integrity.It would be beneficial to expand the test coverage to include additional configuration parameters, particularly new or complex ones introduced in recent updates, to ensure comprehensive validation.
…2097) * Get rid of the cometbft replace and bump it to v0.38.10 (from v0.38.9). * Add changelog entry. * Fix changelog entry. * Fix the config test that broke because it has the comet version number in it that just changed.
Description
This PR bumps
github.com/cometbft/cometbfttov0.38.10(fromv0.38.10-pio-1).We forked cometbft and tagged
v0.38.10-pio-1atc2405cc8f: "feat: do not start indexer service (back port: #3331) (#3496)" because we needed some fixes that had been applied tov0.38.x, but hadn't yet been part of a release.The only difference between
v0.38.10-pio-1andv0.38.10is 5f59b42: "chore: releasev0.38.10(#3515)". The only thing in that commit/PR that isn't changelog changes, is an update to the version number (which gets reported in stuff likeprovenanced status).I fired up a testnet node at
23564251and let it catch up, then run normally for the evening; it's just hit23590370as I'm writing this. So I'm pretty confident that this is not a state-breaking change.The only real change that this PR makes is that version string. Other than that, this PR is mostly just to get us off of the fork and back onto the primary libary.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Dependencies
github.com/cometbft/cometbftto versionv0.38.10.github.com/cosmos/cosmos-sdkwithgithub.com/provenance-io/cosmos-sdkat versionv0.50.7-pio-1.Configuration