Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rosetta #1981

Merged
merged 4 commits into from
May 17, 2024
Merged

Remove Rosetta #1981

merged 4 commits into from
May 17, 2024

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented May 17, 2024

Description

This PR removes all the Rosetta stuff. It's now a stand-alone service. See https://github.com/cosmos/rosetta for more info.

Related to:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Summary by CodeRabbit

  • Removals
    • Rosetta functionality removed from the provenanced executable; now a stand-alone service.
    • test-rosetta target and related commands removed from the Makefile.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

The recent updates focus on restructuring and simplifying the Provenanced blockchain commands and infrastructure. The provenanced query account command has been replaced with provenanced query auth account, and genesis-related commands have been reorganized into a new sub-command. Additionally, the Rosetta service has been decoupled from the provenanced executable and is now a standalone service. Corresponding changes have been made to the Makefile and command initialization to reflect these updates.

Changes

File Change Summary
CHANGELOG.md Updated to reflect command changes, reorganization, and Rosetta service removal.
Makefile Removed test-rosetta target and related Docker build/compose instructions.
cmd/provenanced/cmd/root.go Removed Rosetta command initialization and error handling adjustments.

🐰
In the land of code, a change took place,
Commands reshuffled, found a new space.
Rosetta now stands on its own,
In the blockchain world, it's fully grown.
Genesis commands, a fresh new face,
Provenance marches at a brisker pace.
🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon marked this pull request as ready for review May 17, 2024 19:46
@SpicyLemon SpicyLemon requested a review from a team as a code owner May 17, 2024 19:46
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (5)
CHANGELOG.md (5)

Line range hint 105-350: Consider using a consistent list marker style in markdown.

- 105: -
+ 105: *
- 106: -
+ 106: *
...
- 350: -
+ 350: *

Line range hint 813-813: Remove consecutive blank lines to maintain a clean and consistent document structure.

- 813: 

- 1214: 

- 1231: 

- 1283: 

- 1387: 

Also applies to: 1214-1214, 1231-1231, 1283-1283, 1387-1387


Line range hint 224-224: Convert bare URLs to markdown links to improve the readability and presentation of the document.

- 224: https://github.com/provenance-io/provenance/issues/224
+ 224: [Issue #224](https://github.com/provenance-io/provenance/issues/224)
...
- 899: https://github.com/provenance-io/provenance/issues/899
+ 899: [Issue #899](https://github.com/provenance-io/provenance/issues/899)

Also applies to: 255-255, 354-354, 404-404, 416-416, 432-432, 503-503, 514-514, 522-522, 558-558, 583-583, 595-595, 641-645, 692-692, 733-733, 786-786, 899-899


Line range hint 941-941: Remove spaces inside emphasis markers to correct the markdown syntax.

- 941: * message *
+ 941: *message*

Line range hint 337-337: Remove spaces inside code span elements to adhere to markdown best practices.

- 337: ` MsgAddMarkerRequest `
+ 337: `MsgAddMarkerRequest`
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f0c80ca and 4fea625.
Files ignored due to path filters (1)
  • go.mod is excluded by !**/*.mod
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • Makefile (1 hunks)
  • cmd/provenanced/cmd/root.go (1 hunks)
Files skipped from review due to trivial changes (2)
  • Makefile
  • cmd/provenanced/cmd/root.go

@SpicyLemon SpicyLemon enabled auto-merge (squash) May 17, 2024 19:59
@SpicyLemon SpicyLemon merged commit ef6b255 into main May 17, 2024
26 of 36 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/1760-rosetta branch May 17, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants