Add the quarantine module. #1926
Conversation
…fruit compilation issues in some of those files too.
… some other stuff in there.
… testutil imports.
…x a few easy compilation issues.
…quarantine/testutils. Get rid of all dot imports.
# Conflicts: # app/app.go # app/sim_test.go # client/docs/statik/statik.go # client/docs/swagger-ui/swagger.yaml
…e name, and fix all the simulation unit tests.
…of the overall timeout.
…ked some coins stuff related to empty or nil.
…e an exchange keeper sanction action.
WalkthroughThe changes reintroduce the Quarantine module into the Changes
Assessment against linked issues
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (6)
Files selected for processing (54)
Files not processed due to max files limit (19)
Additional Context UsedLearnings (1)
Additional comments not posted (157)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
# Conflicts: # app/app.go # client/docs/statik/statik.go # x/README.md # x/marker/keeper/keeper_test.go
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
Actionable comments outside the diff hunks (13)
CHANGELOG.md (13)
Line range hint
61-168: Consider using a consistent list marker style in markdown.- - + *
Line range hint
172-172: Enclose bare URLs in angle brackets to make them clickable in markdown.- https://github.com/provenance-io/provenance/compare/v1.17.1...v1.18.0 + <https://github.com/provenance-io/provenance/compare/v1.17.1...v1.18.0>
Line range hint
197-197: Consider using a consistent list marker style in markdown.- - + *
Line range hint
276-298: Consider using a consistent list marker style in markdown.- - + *
Line range hint
654-654: Consider using a consistent list marker style in markdown.- - + *
Line range hint
662-662: Consider using a consistent list marker style in markdown.- - + *
Line range hint
707-707: Consider using a consistent list marker style in markdown.- - + *
Line range hint
715-715: Consider using a consistent list marker style in markdown.- - + *
Line range hint
761-761: Remove extra blank lines to maintain a clean and consistent markdown file.-
Line range hint
1162-1162: Remove extra blank lines to maintain a clean and consistent markdown file.-
Line range hint
1179-1179: Remove extra blank lines to maintain a clean and consistent markdown file.-
Line range hint
1231-1231: Remove extra blank lines to maintain a clean and consistent markdown file.-
Line range hint
1335-1335: Remove extra blank lines to maintain a clean and consistent markdown file.-
Description
Closes: #1902
Copy the quarantine module from our SDK fork and add it back into our app.
All the quarantine (and sanction) unit tests pass now. :D
Related:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
New Features
Refactor
Documentation