Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow groups to force transfer. #1821

Merged
merged 15 commits into from
Jan 26, 2024
Merged

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Jan 24, 2024

Description

Allows force transfers to be done with group accounts, and prevent the marker keeper from needing a dependency on the groups module.

closes: #1818


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo self-assigned this Jan 24, 2024
dependabot bot and others added 8 commits January 24, 2024 15:00
* Bump github.com/google/uuid from 1.5.0 to 1.6.0

Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Changelog](https://github.com/google/uuid/blob/master/CHANGELOG.md)
- [Commits](google/uuid@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7615d6) 73.98% compared to head (604db52) 73.99%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage   73.98%   73.99%           
=======================================
  Files         315      316    +1     
  Lines       44826    44839   +13     
=======================================
+ Hits        33165    33178   +13     
  Misses      10277    10277           
  Partials     1384     1384           
Files Coverage Δ
app/app.go 85.68% <100.00%> (+0.03%) ⬆️
app/group.go 100.00% <100.00%> (ø)
x/marker/keeper/keeper.go 80.57% <100.00%> (+0.11%) ⬆️
x/marker/keeper/marker.go 57.07% <100.00%> (-0.14%) ⬇️

@Taztingo Taztingo changed the title Add permission checker to see if an account is part of a group for ma… Allow groups to force transfer. Jan 25, 2024
@Taztingo Taztingo marked this pull request as ready for review January 25, 2024 19:36
@Taztingo Taztingo requested a review from a team as a code owner January 25, 2024 19:36
@Taztingo Taztingo enabled auto-merge (squash) January 25, 2024 20:11
@Taztingo Taztingo added this to the v1.18.0 milestone Jan 25, 2024
app/group.go Show resolved Hide resolved
@Taztingo Taztingo merged commit c843436 into main Jan 26, 2024
40 checks passed
@Taztingo Taztingo deleted the taztingo/1818-privilege-transfer branch January 26, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Unable to marker transfer from a group account
3 participants