-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove update block latency procedure call #550
Merged
nullpointer0x00
merged 14 commits into
main
from
nullpointer0x00/remove-latency-calculation
Sep 20, 2024
Merged
Remove update block latency procedure call #550
nullpointer0x00
merged 14 commits into
main
from
nullpointer0x00/remove-latency-calculation
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry, comment out validator lag for now
nullpointer0x00
changed the title
Remove latency calculation
Remove update block latency procedure call
Sep 19, 2024
scirner22
approved these changes
Sep 20, 2024
nullpointer0x00
deleted the
nullpointer0x00/remove-latency-calculation
branch
September 20, 2024 00:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
block_latency
calculation logic from both the Kotlin code and the PostgreSQL stored procedure. The reason for this removal is that calculating latencies for large ranges of blocks would cause the process to run for hours without completing, which halted block collection.Key Changes:
block_latency
calculation: The stored procedureupdate_block_latency()
and all references toblock_latency
in the Kotlin code have been removed.block_latency
.By removing this, we avoid performance issues that were affecting block collection, especially when handling large datasets.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes