Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update block latency procedure call #550

Merged
merged 14 commits into from
Sep 20, 2024

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Sep 19, 2024

Description

This PR removes the block_latency calculation logic from both the Kotlin code and the PostgreSQL stored procedure. The reason for this removal is that calculating latencies for large ranges of blocks would cause the process to run for hours without completing, which halted block collection.

Key Changes:

  1. Removed block_latency calculation: The stored procedure update_block_latency() and all references to block_latency in the Kotlin code have been removed.
  2. Code cleanup: Simplified queries and removed unnecessary logic that dealt with block_latency.

By removing this, we avoid performance issues that were affecting block collection, especially when handling large datasets.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 changed the title Remove latency calculation Remove update block latency procedure call Sep 19, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review September 19, 2024 21:05
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner September 19, 2024 21:05
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) September 19, 2024 21:11
@nullpointer0x00 nullpointer0x00 merged commit bba7b8e into main Sep 20, 2024
4 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/remove-latency-calculation branch September 20, 2024 00:53
@nullpointer0x00 nullpointer0x00 self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants