Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* [1046]: Update the bank module to allow for a sanction keeper. * [1046]: Create sanction protos and make proto-gen. * [1046]: In the BlockGas unit test, set the sanction keeper to nil to keep costs the same as when the test was written. * [1046]: Get the updated ReadPageRequest stuff from the quarantine branch. * [1046]: make proto-gen on the bank module to get the updated comments. * [1046]: Fix the package of the query proto. * [1046]: Change the IsSanctioned keeper method into IsSanctionedAddr to avoid a conflict with the name of the query server method. * [1046] Create the sanction module and stub out everything it needs. * [1046]: Start fleshing out the keeper functions. * [1046]: Update protos. Remove the immediate messages. Add endpoints for querying and updating params. * [1046]: make proto-format to fix some pre-existing formatting. * [1046]: Make proto-gen. * [1046]: Rename SanctionImmediateParams to just ImmediateParams. * [1046]: Implement all the ValidateBasic msg funcs. Update the genesis type stuff to account for the params and provide stuff for default params. * [1046]: Rename a couple keeper funcs to hopefully make them more accurate and clearer. * [1046]: Update the msg server and grpc query keepers to reflect removal of immediate endpoints and addition of params stuff. * [1046]: Implement the store decoder (for simulation). * [1046]: Rename the params stuff. * [1046]: More renaming of some params-related stuff and addition of keeper stuff for params in state. * [1046]: Fix the name of the addresses field in the query response. * [1046]: Add a query for temporary entries. * [1046]: Implement the grpc queries. * [1046]: init and export genesis. * [1046]: Implement the msg server stuff. * [1046]: Emit the events. * [1046]: Change the IsSanctioned REST endoint to 'check' (from 'active') because I think that's a better name for it. * [1046]: Implement the cli query commands. * [1046]: Remove the tx command stuff since it's all gov props. * [1046]: Do the governance hooks for the most part. * [1046]: Refactor some keys stuff and add a proposal->temp index. Made the params prefix 0x00 and bumped the rest up one. Moved the params-related functions to the top. Fixed variables named Id because gofmt says (incorrectly IMO) that it should be ID. * [1046]: Update the keeper. When creating/deleting temp entries, also do the gov prop index entries. When sanctioning or unsanctioning addresses, also delete their temp entries (and those indexes). Add some msgTypeURLs to the keeper so that they're defined once and after everything's registered (hopefully), and usable by the gov_hooks stuff. * [1046]: Update the gov hooks to account for the temp stuff being cleaned up when a proposal passes and also account for the proposal in question not being found. Also, make sure the min immediate deposit isn't zero before making the temp entries. * [1046]: Handle the proposal message being a MsgExecLegacyContent wrapping what we really want. * [1046]: Turns out the Coins proto fields need to have nullable = false. Bah. * [1046]: Enhance the genesis state validation invalid address message to include the bad addr and error. * [1046]: Unit tests on the genesis types funcs. * [1046]: Enhance the msg ValidateBasic error messages to include more info. * [1046]: Fix a var name. * [1046]: Unit tests on the Msg functions. * [1046]: Lint fix. * [1046]: Unit tests on the sanction params simple stuff. * [1046]: Start in on keys unit tests. * [1046]: Some more keys tests and bedtime. * [1046]: Update the key prefix creators to return a copy of the prefix bytes if the provided thing isn't provided. That way, the thing returned doesn't have extra capacity if we're not expecting to need it. * [1046]: Finish the keys tests. * [1046]: Add the sanction keeper to the app. * [1046]: Remove the bank keeper from the sanction keeper since it's not needed anywhere but the constructor (to tell the bank keeper about itself). Change IsSanctionableAddr to take in an AccAddress and use the stringified addresses in the map instead of the bech32s; the place where I wanted to call it already has them as AccAddresses. When adding either a sanction or temp sanction, make sure the address is sanctionable first. * [1046]: Start in on the keeper tests. * [1046]: In IsSanctionedAddr, return false if no addr is provided. Same in IsSanctionableAddr. * [1046]: Make isSanctionableAddr private because it's so closely named with IsSanctionedAddr and probably isn't that helpful outside the module. If I decide to make it public again, I'll need to come up with a different name. * [1046]: Some more progress on the keeper unit tests. * [1046]: Rename isSanctionableAddr to IsAddrThatCannotBeSanctioned and refactor its use. For temp sanctions, move the check into addTempEntries. In IsSanctionedAddr, check IsAddrThatCannotBeSanctioned first, just to be safe. When looking up the latest temp addr, make sure an addr is provided (otherwise it just gets the first temp entry in the store for any addr). Add some comments. * [1046]: Finish up the keeper tests. * [1046]: Add temp entries to the genesis proto. * [1046]: Add temp entries to init/export genesis. * [1046]: Fix bank unit tests so they compile. Remove the AppModule.Name function since AppModuleBasic requires it too, so it's just being double defined. * [1046]: Update the sanction simulation store decoder to include the proposal index prefixed keys. * [1046]: Add the sanction module to the migration tests since the store key is needed due to the restriction. * [1046]: When creating the simapp, give the correct gov keeper to the sanction keeper constructor. Also, provide it as a reference so that it's later updated appropriately. * [1046]: Unpack the MsgExecLegacyContent into a reference to it, since that's what the any has and what the codec can decode. * [1046]: Rename the keeper test funcs to be more in line with standards. * [1046]: Allow the genState to be nil to InitGenesis. Fix the addr error check in there. Add more context to several of the panic messages in InitGenesis. * [1046]: Tweak AssertErrorContents to read a bit better. Tweak AssertPanicsWithMessage to have better failure messages. Create AssertPanicContents and AssertNotPanicsNoError and their Require partners. * [1046]: Prepend OnlyTests to the exported test-only functions. * [1046]: Add unit tests on genesis keeper funcs. * [1046]: Tweak the keys tests that check for duplicate values to only have one sub-test per entry and do the duplicate checking under that. Also give them better error messages. Add similar tests on the msg urls in the keeper. * [1046]: Rename the TestSuite to KeeperTestSuite since I decided not to just put all keeper tests on that struct. * [1046]: Get rid of unwrapLegacyGovPropMsg. Our new stuff doesn't implement the Content interface, so it can't be in a legacy exec message. Also make things play nicer with nils; probably not needed, but whatever, it makes tests happier. * [1046]: Create a BaseTestSuite with the stuff needed in the keeper tests, and have the keeper and genesis tests just expand off that object. The BaseTestSuite is a nice place to put commonly needed functions like ClearState. Also, I made all those funcs public since it's for unit testing and there's no good reason to try to keep any of it private. * [1046]: Move ExportAndCheck out of the genesis test suite into the base one and create a GetStore func since that's a commmonly needed thing in here. * [1046]: Most of the gov hooks tests, at least on the smaller pieces. Starting in on the proposalGovHook tests. * [1046]: Tweak the keeper a bit. When creating a temp entry, emit the event after writing both keys just to group logic together. Refactor DeleteGovPropTempEntries to built the keys-to-delete list in the iterator and get the store if there's something to delete. In DeleteAddrTempEntries, only create the store if there's something to delete. Now those two are designed the same way. * [1046]: Fix the proposalGovHook. As it was, it would do nothing if the proposal wasn't found since there wouldn't be any messages to loop through. Basically, put the status switch at the top level and only loop through the messages when in deposit or voting period since those are the only cases where we care about what the proposal had. * [1046]: change the unknown gov prop panic message to invalid. * [1046]: Finish up the proposalGovHook tests. * [1046]: grpc query tests. * [1046]: Tweak some error messages from the msg server. * [1046]: Unit test on the msg server endpoints. * [1046]: Add some bank module tests. * [1046]: Unit tests on the CLI queries. * [1046]: Simulation decoder test. * [1046]: Implement that simulation random genesis state. * [1046]: Tweak the RandomParams function to a) have much lower values (more in line with what accounts might have), and b) have a 20% chance of being nil. Add function comments to the simulation genesis funcs. * [1046]: Unit tests on the simulation genesis funcs. * [1046]: Stub out the simulation weighted ops stuff. Add the governance keeper to the module so we can look up the gov prop deposit requirements. * [1046]: Write up all the simulation operations. * [1046]: Fix maxCoins, make it public, and add unit tests on it. * [1046]: Make SendGovMsg and OperationMsgVote public so it can be unit tested. Remove the AnyUnpacker since it's not used. Properly set the sanction keeper in the args. * [1046]: Provide a ProtoCodec to the WeightedOperations function. It's needed because we don't implement LegacyMsg stuff. Provide it when sending things. Clean things up a bit. Set the op msg comment to indicate what's going on since they're all gov props. Send the whole deposit instead of picking a denom since all the denoms are needed anyway. * [1046]: Write TestWeightedOperations. * [1046]: For immediate ops, use r to decide yes or no vote before it gets used for anything else. * [1046]: Add a few test cases to the MaxCoins tests. * [1046]: Unit tests on SendGovMsg. * [1046]: Rename a OperationMsgVote argument to voter (from simAccount) for extra clarity. * [1046]: In TestSendGovMsg, if we expect it to be successful, get the gov prop and make sure it's actually there. * [1046]: Unit tests on OperationMsgVote. * [1046]: If there's an error getting the proposal id (no clue how), don't create the future ops. * [1046]: Unit tests on SimulateGovMsg Sanction and Unsanction. * [1046]: Some function comments. * [1046]: Slight tweak to some variable names (accs instead of accts) and some comment tweaks. * [1046]: Unit tests on the simulation immediate stuff. * [1046]: In SimulateGovMsgUpdateParams, generate the random params before picking the sender. * [1046]: Unit tests on SimulateGovMsgUpdateParams. * [1046]: Refactor the sims to a) only sanction new addrs because sanctioning known accounts causes other sims to fail, and b) unsanction addresses that are sanctioned instead of just using random addresses. * [1046]: When creating the random genesis state, use fresh addresses instead of existing ones since using existing ones breaks all the other ops. * [1046]: Set the gov keeper in the module, just as nature intended. * [1046]: Provide the maccPerms account addresses as unsanctionable. * [1046]: First draft of the spec documentation. * [1046]: Fix some spec doc stuff. * [1046]: Fix a couple comments copied from the quarantine stuff. * [1046]: Fix an event comment. * [1046]: Add some more missing proto comments. * [1046]: Add a nondeterministic warning to ModuleAccounts. * [1046]: Add a missing comment on the GovKeeper expected interface. * [1046]: Add genesis validation on the temporary entries. * [1046]: Fix a couple test names. * [1046]: Fix a few comments on the gov hooks. * [1046]: Some lint fixes. * [1046]: Fix a couple function comments in the keeper. * [1046]: Add RequireNotPanicsNoError to the BaseTestSuite and use that in a bunch of places to clean stuff up. * [1046]: use 0x01 for the sanction state value to match the temp value. Rename the TempSanctionB and TempUnsanctionB stuff to not have Temp so they can be used for permanent if desired. * [1046]: Some more test cleanup to make better use of some of the setup helper functions used elsewhere. * [1046]: Slight tweak to a comment. * [1046]: Get rid of the getSeedValue and replace it with a func that just creates the new rand with that seed value since it's used exactly like that for all calls. * [1046]: Update state spec docs to reflect the change of sanctioned addr value to 0x01 (from 0x00). * [1046]: Refactor AssertNotPanicsNoError to make it less confusing. Previously, at first glance, it looked like it wasn't returning the right thing when it all passed because the last line was return false. But the last line was only getting used if there was a panic. So while it was returning correctly, it was confusing to read. So I fixed that (hopefully). * [1046]: Tweak the concepts a bit for wording and put the complex interactions at the end. * [1046]: Add an integration test that sanctions a validator. * [1046]: Add alias c to the is-sanctioned CLI command. * [1046]: Add changelog entry. * [1046]: Add the sanction module to the main spec readme list.
- Loading branch information
1 parent
3aeadb3
commit 7ea989a