Skip to content

Commit

Permalink
Merge pull request #564 from provenance-io/egaxhaj/fix-additional-bin…
Browse files Browse the repository at this point in the history
…dings-tags

expand additional_bindings so they can be parsed with protobufjs
  • Loading branch information
egaxhaj authored and SpicyLemon committed Mar 20, 2023
1 parent e2f58e7 commit 2226772
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ Ref: https://keepachangelog.com/en/1.0.0/

## Unreleased

* nothing
### Bug Fixes

* [PR 564](https://github.com/provenance-io/cosmos-sdk/pull/564) Fix protobufjs parse error by using object form vs. array for `additional_bindings` rpc tag.

---

Expand Down
14 changes: 9 additions & 5 deletions proto/cosmos/quarantine/v1beta1/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ service Query {
rpc QuarantinedFunds(QueryQuarantinedFundsRequest) returns (QueryQuarantinedFundsResponse) {
option (google.api.http) = {
get: "/cosmos/quarantine/v1beta1/funds"
additional_bindings: [
{get: "/cosmos/quarantine/v1beta1/funds/{to_address}"},
{get: "/cosmos/quarantine/v1beta1/funds/{to_address}/{from_address}"}
]
additional_bindings: {
get: "/cosmos/quarantine/v1beta1/funds/{to_address}"
}
additional_bindings: {
get: "/cosmos/quarantine/v1beta1/funds/{to_address}/{from_address}"
}
};
}

Expand All @@ -38,7 +40,9 @@ service Query {
rpc AutoResponses(QueryAutoResponsesRequest) returns (QueryAutoResponsesResponse) {
option (google.api.http) = {
get: "/cosmos/quarantine/v1beta1/auto/{to_address}"
additional_bindings: [{get: "/cosmos/quarantine/v1beta1/auto/{to_address}/{from_address}"}]
additional_bindings: {
get: "/cosmos/quarantine/v1beta1/auto/{to_address}/{from_address}"
}
};
}
}
Expand Down
1 change: 0 additions & 1 deletion proto/cosmos/tx/v1beta1/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ message GetTxsEventRequest {
// pagination defines a pagination for the request.
// Deprecated post v0.46.x: use page and limit instead.
cosmos.base.query.v1beta1.PageRequest pagination = 2 [deprecated = true];
;
OrderBy order_by = 3;
// page is the page number to query, starts at 1. If not provided, will default to first page.
uint64 page = 4;
Expand Down

0 comments on commit 2226772

Please sign in to comment.