Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Make webclient use system proxy #3881

Merged
merged 3 commits into from
May 30, 2023
Merged

BE: Make webclient use system proxy #3881

merged 3 commits into from
May 30, 2023

Conversation

Haarolean
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Make webclient use system proxy. Fixes #3868

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/bug Something isn't working scope/backend labels May 30, 2023
@Haarolean Haarolean requested a review from a team as a code owner May 30, 2023 10:38
@Haarolean Haarolean self-assigned this May 30, 2023
@Haarolean Haarolean changed the title BE: Make webclient use system proxy. BE: Make webclient use system proxy May 30, 2023
@Haarolean Haarolean merged commit f19abb2 into master May 30, 2023
@Haarolean Haarolean deleted the issues/3868 branch May 30, 2023 12:27
Haarolean added a commit that referenced this pull request Jun 27, 2023
Co-authored-by: Ilya Kuramshin <iliax@proton.me>
(cherry picked from commit f19abb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version Check Doesn't Use Proxy Settings
2 participants