Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrades package.jsons & READMEs #48

Merged
merged 23 commits into from
Mar 12, 2019

Conversation

gskapka
Copy link
Contributor

@gskapka gskapka commented Mar 5, 2019

...per title.

🏷️ Changes:

  • Truffle (and any other missing packages) added to package.json.

  • Now uses npx instead of direct paths to run truffle and the bridge.

  • Instructions in the READMEs reflect the above.

  • JS has been linted and brought inline to more recent standards.


🖍️ Note:

To the reviewer - these each need pulling and checking that they all work correctly when following READMEs instructions please!

@gskapka gskapka self-assigned this Mar 5, 2019
@gskapka
Copy link
Contributor Author

gskapka commented Mar 12, 2019

📯 Update:

Post-install scripts now implemented to stop dual-lib errors.

@gskapka gskapka closed this Mar 12, 2019
@gskapka gskapka reopened this Mar 12, 2019
...via package.json & the lock files. Also drop the web3 dependency
version where necessary due to bug in later versions causing
test-failure.
@gskapka gskapka force-pushed the chore/upgrade-package-jsons-and-readmes branch from ca18e0e to bb408a9 Compare March 12, 2019 15:38
@gskapka
Copy link
Contributor Author

gskapka commented Mar 12, 2019

📯 Update:

  • ethereum-bridge's bitcore dependency that gave rise to the dual-dependency error now fixed and so post-install script workarounds herein have been removed.

  • Also added shrinkwrap.yaml's to ensure pnpm compatibility.

...solving various issues with missing imports &c.
Copy link
Contributor

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm

@gskapka gskapka merged commit 328a72f into master Mar 12, 2019
@gskapka gskapka deleted the chore/upgrade-package-jsons-and-readmes branch March 12, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants