-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .editorconfig for csharp directory #9675
Add .editorconfig for csharp directory #9675
Conversation
Nicer experience for e.g. VS Code
|
||
# New line preferences | ||
# See https://github.com/protocolbuffers/protobuf/issues/9526 | ||
#end_of_line = lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet - we may well do that as part of fixing #9526, but this PR just adds the editor config without trying to address that.
Please add the file to |
Done...for my own curiosity, what is that file for? I'm guessing it's for packaging up the e.g. protobuf-csharp-3.20.0.zip zip/tar files on the releases, for users who want to consume as source? |
@Jensaarai: That's my understanding, yes. It was already in place when I started contributing to the project, and I haven't gone into great depths to check it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this now - it'll help with #9526.
Nicer experience for e.g. VS Code
Split from #9666