-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QNX 7.0 support #8593 #8637
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Looks mostly good, but I would like to have Jan take a look because of the aarch64 change in src/google/protobuf/stubs/platform_macros.h |
@dschopf Please include the missing labels |
Sorry, I can't do that, looks like I don't have permission to add or edit labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any experience with QNX, but the change in platform_macros.h seems fair
(and it only kicks in when __QNX__
is defined, so I don't think it can break the aarch64 linux support in any way).
I'll let @fowles to review the rest of the code and give the final approval.
These changes resolve all issues described in #8593 except for the linker issue.