Include the size of values (and tags) for extensions, even if the value is the default #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue is the default Fixes protocolbuffers#8218.
|
Ping @haberman @jtattermusch |
jtattermusch
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
LGTM from the C# perspective.
Also LGTM from the protobuf perspective but I'd rather defer to @haberman 's opinion there.
|
Yes this LGTM. Extensions should always be serialized if present, and should never have the proto3 behavior of comparing with the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8218.