Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven-surefire-plugin to 3.0.0-M5. #7830

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

cpovirk
Copy link
Contributor

@cpovirk cpovirk commented Aug 19, 2020

This avoids https://issues.apache.org/jira/browse/SUREFIRE-1439,
which I hit while investigating
#7827

@haberman
Copy link
Member

This appears to make the Java Kokoro tests fail.

@cpovirk
Copy link
Contributor Author

cpovirk commented Oct 22, 2020

Sounds like it may be from using an older version of Maven (3.0.5, which looks to be a couple years old). The current version is 3.6.3. Any idea whether it makes sense to update it and, if so, where that's configured?

@cpovirk
Copy link
Contributor Author

cpovirk commented Oct 22, 2020

Hmm, looks like maybe you just get whatever is in the Debian VM you launch?


One is on Debian "stretch," the other on "latest":


FROM debian:latest

Whatever Debian I have on my laptop has Maven 3.6.3, but maybe that's newer than those two?

From the failure output, I get the impression that the relevant Dockerfile is kokoro/linux/64-bit/Dockerfile. I'm not sure what "latest" means, though.

@elharo
Copy link
Contributor

elharo commented Oct 13, 2021

still seem to be using Maven 3.0.5, need to fix that somehow

@elharo
Copy link
Contributor

elharo commented Oct 13, 2021

Debian is known to have issues with very old Maven versions

@elharo
Copy link
Contributor

elharo commented Oct 13, 2021

The problem is we use apt-get to install maven. Debian is way, way out of date. We need to figure out an alternate means of installing a more current Maven, either a different image, a different repo, or a manual install of some kind.

@elharo
Copy link
Contributor

elharo commented Oct 13, 2021

@acozzette
Copy link
Member

We ended up dropping our Java 7 tests, which were the ones using the old Debian version, so I believe this is now OK to merge.

@acozzette acozzette merged commit 62d59d7 into protocolbuffers:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants