-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a proto_lang_toolchain for javalite #6882
Conversation
@ejona86 do you know how can I test it? Is there a |
It looks like your examples include a java_lite_proto_library :) Lines 73 to 76 in 4e93585
(And I only know this because of the build failure you mentioned in #6898) That means you should also update it's workspace to use a Lines 24 to 28 in 4e93585
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a bug and updated the examples, but now it is running for me. You can test by cd examples/; bazel build :addressbook_java_lite_proto
Thank you very much :) |
* Add a proto_lang_toolchain for javalite * fix toolchain. Swap javalite example to master repo
* Add a proto_lang_toolchain for javalite * fix toolchain. Swap javalite example to master repo
So that javalite can be used from Bazel. Related discussion: #6867