Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js message support for jstype string on integers #4332

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

cmoad
Copy link
Contributor

@cmoad cmoad commented Feb 24, 2018

Naive attempt to fix #4025. I'm not familiar with how to test a fork of an npm package, so any guidance on that would be great.

@googlebot
Copy link

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@cmoad
Copy link
Contributor Author

cmoad commented Feb 24, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@TeBoring
Copy link
Contributor

TeBoring commented Apr 2, 2018

Internally, we already have the fix. We will opensource it in the next release.

@TeBoring TeBoring merged commit 579f81e into protocolbuffers:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: jspb.Message.setProto3StringIntField is not a function
4 participants