-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper fix utf8 command line arguments #14253
Proper fix utf8 command line arguments #14253
Conversation
Fyi @fowles |
a bunch of stuff in our repo/ci moved around recently. Can you rebase this change? |
@hknielsen pending comments and needs a rebase |
Hi @hknielsen, do you plan to continue working on this CL? Thanks! |
88b3c6e
to
cfbdd35
Compare
8e9879b
to
881ae8e
Compare
yeah, we have to go back to the |
Reverted back to |
|
Nothing for you to do. There was a merge conflict on internal import that I will handle |
#14197 Tried to fix utf-8 issue, but it didnt handle multibyte chars. Only way I found that works constantly is using `CommandLineToArgvW`. To not ripple out `wchar_t`, I convert to and from where needed Closes #14253 COPYBARA_INTEGRATE_REVIEW=#14253 from hknielsen:proper-fix-none-ascii-issue cad753e FUTURE_COPYBARA_INTEGRATE_REVIEW=#14253 from hknielsen:proper-fix-none-ascii-issue cad753e PiperOrigin-RevId: 599826579
We have received several reports in #17036 that the addition of this flag actually broke the use of command argument files with non-ASCII characters in their names. It looks like #14253 ended up fixing the original issue with a different solution anyway. Hopefully this change fixes the issue with non-ASCII characters. PiperOrigin-RevId: 655201610
We have received several reports in #17036 that the addition of this flag actually broke the use of command argument files with non-ASCII characters in their names. It looks like #14253 ended up fixing the original issue with a different solution anyway. Hopefully this change fixes the issue with non-ASCII characters. PiperOrigin-RevId: 655201610
We have received several reports in #17036 that the addition of this flag actually broke the use of command argument files with non-ASCII characters in their names. It looks like #14253 ended up fixing the original issue with a different solution anyway. Hopefully this change fixes the issue with non-ASCII characters. PiperOrigin-RevId: 655660885
We have received several reports in #17036 that the addition of this flag actually broke the use of command argument files with non-ASCII characters in their names. It looks like #14253 ended up fixing the original issue with a different solution anyway. Hopefully this change fixes the issue with non-ASCII characters. PiperOrigin-RevId: 655660885
We have received several reports in #17036 that the addition of this flag actually broke the use of command argument files with non-ASCII characters in their names. It looks like #14253 ended up fixing the original issue with a different solution anyway. Hopefully this change fixes the issue with non-ASCII characters. PiperOrigin-RevId: 655660885
#14197
Tried to fix utf-8 issue, but it didnt handle multibyte chars.
Only way I found that works constantly is using
CommandLineToArgvW
.To not ripple out
wchar_t
, I convert to and from where needed