port_def: Ignore -Wpedantic warnings #13492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaski
requested review from
esorot and
acozzette
and removed request for
a team
fowles
reviewed
Aug 9, 2023
Fixes `extra ';' [-Wpedantic]` warnings in generated `.pb` headers.
jonaski
changed the title
fowles
approved these changes
Aug 9, 2023
github-actions
bot
removed
the
🅰️ safe for tests
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
Arena enabled copy construction provides efficiency gains for the rather common construct where a message is currently copied by first creating a default initialized instance through the regular (arena) constructor, and then recursively filled from the source message using 'MergeFrom' or 'CopyFrom'. Arena enabled copy construction is feature gated in port_def.inc and currently not enabled by default. COPYBARA_INTEGRATE_REVIEW=#13492 from jonaski:pedantic_extra_semicolon a226328 FUTURE_COPYBARA_INTEGRATE_REVIEW=#13492 from jonaski:pedantic_extra_semicolon a226328 PiperOrigin-RevId: 550942711
dawidcha
pushed a commit
to dawidcha/protobuf
that referenced
this pull request
Sep 27, 2023
Ignores warning: extra ';' inside a struct [-Wextra-semi] in generated proto files. Amends protocolbuffers#13492 Closes protocolbuffers#13859 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#13859 from jonaski:ports_def_clang_extra-semi de5965a PiperOrigin-RevId: 564013323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
extra ';' [-Wpedantic]warnings in generated.pbheaders.