Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto capitalize enums name in Ruby (#10454) #10763

Merged

Conversation

tisonkun
Copy link
Contributor

This closes #1965.

@tisonkun
Copy link
Contributor Author

@deannagarcia @mkruskal-google emmm...IIRC I open this PR against 21.x but it's now merged into master (and I don't find the commit on master). What should I do now? @deannagarcia @mkruskal-google could you help with cherrypicking this patch?

Originally posted by @tisonkun in #10708 (comment)

@mkruskal-google
Copy link
Member

Yea I suspect the commit was just dropped because it was a duplicate of #10454. This one looks properly cherry picked

@mkruskal-google mkruskal-google merged commit fa5a9e1 into protocolbuffers:21.x Oct 13, 2022
mkruskal-google added a commit that referenced this pull request Oct 19, 2022
* Force uninstall protobuf in python macos builds

We are seeing failures in brew uninstall protobuf due to no package. Change this to a force install to avoid the error.

* Fix spelling errors (#10717)

* Merge pull request #10200 from tonydnewell/bugfix/protobuf-7474

Fix for grpc.tools #17995 & protobuf #7474 (handle UTF-8 paths in argumentfile)

* Upgrade to kotlin 1.6

* 21.x No longer define no_threadlocal on OpenBSD

* Upgrade kokoro to Xcode 14 (#10732)

* Upgrade kokoro to Xcode 14

* Fix osx errors

* Merge pull request #10770 from protocolbuffers/googleberg-cl-480629524

Mark default instance as immutable first to avoid race during static initialization of default instances.

* Auto capitalize enums name in Ruby (#10454) (#10763)

This closes #1965.

* Edit toolchain to work with absl dep

* Bump upb to latest version after fixes applied (#10783)

* 21.x 202210180838 (#10785)

* Updating version.json and repo version numbers to: 21.8

* Update changelog

Co-authored-by: Protobuf Team Bot <protobuf-team-bot@google.com>

* Update generated protos

Co-authored-by: deannagarcia <69992229+deannagarcia@users.noreply.github.com>
Co-authored-by: Matt Fowles Kulukundis <matt.fowles@gmail.com>
Co-authored-by: Deanna Garcia <deannagarcia@google.com>
Co-authored-by: Brad Smith <brad@comstyle.com>
Co-authored-by: Jerry Berg <107155935+googleberg@users.noreply.github.com>
Co-authored-by: tison <wander4096@gmail.com>
Co-authored-by: Protobuf Team Bot <protobuf-team-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants