Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazelify ruby runtime #10525

Closed

Conversation

mkruskal-google
Copy link
Member

@mkruskal-google mkruskal-google commented Sep 8, 2022

This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

@mkruskal-google mkruskal-google added ruby bazel release notes: no jruby Issues unique to the JRuby interpreter labels Sep 8, 2022
.gitignore Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
maven_install.json Outdated Show resolved Hide resolved
protobuf_deps.bzl Outdated Show resolved Hide resolved
@mkruskal-google mkruskal-google force-pushed the rules_ruby branch 7 times, most recently from 5d70c6f to 0ece600 Compare December 23, 2022 07:11
@mkruskal-google mkruskal-google changed the title [WIP] Bazelify ruby runtime Bazelify ruby runtime Dec 27, 2022
copybara-service bot pushed a commit that referenced this pull request Dec 27, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code.  The Rakefile is left in place for now and is still used by our aarch64 tests.  With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system.  Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

Closes #10525

COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
PiperOrigin-RevId: 498031251
copybara-service bot pushed a commit that referenced this pull request Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code.  The Rakefile is left in place for now and is still used by our aarch64 tests.  With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system.  Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

Closes #10525

COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
PiperOrigin-RevId: 498031251
copybara-service bot pushed a commit that referenced this pull request Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code.  The Rakefile is left in place for now and is still used by our aarch64 tests.  With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system.  Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

Closes #10525

COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
PiperOrigin-RevId: 498031251
copybara-service bot pushed a commit that referenced this pull request Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code.  The Rakefile is left in place for now and is still used by our aarch64 tests.  With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system.  Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

Closes #10525

COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
PiperOrigin-RevId: 498031251
copybara-service bot pushed a commit that referenced this pull request Jan 3, 2023
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code.  The Rakefile is left in place for now and is still used by our aarch64 tests.  With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system.  Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version

Closes #10525

COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7
PiperOrigin-RevId: 498031251
@copybara-service copybara-service bot closed this in 633e8f7 Jan 3, 2023
@alexeagle alexeagle mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel jruby Issues unique to the JRuby interpreter ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants