Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance Test Failures for Objective-C #6863

Closed
rafi-kamal opened this issue Nov 8, 2019 · 5 comments · Fixed by #6866
Closed

Conformance Test Failures for Objective-C #6863

rafi-kamal opened this issue Nov 8, 2019 · 5 comments · Fixed by #6866
Assignees
@thomasvl

Comments

@rafi-kamal
Copy link
Contributor

rafi-kamal commented Nov 8, 2019 •
edited
Loading

Down integration of Google3 changes (#6858) is breaking the Objective-C tests.

The broken tests have been added recently in cl/276783306. Should I add those to the failure list for now to move forward?
@thomasvl
Copy link
Contributor

thomasvl commented Nov 8, 2019

Go ahead and add them to the excludes, but keep this this open so I look at them.

@thomasvl
Copy link
Contributor

thomasvl commented Nov 8, 2019

I think I have a fix, but I'll wait for the PR to land so I can easily validate it.

thomasvl added a commit to thomasvl/protobuf that referenced this issue Nov 8, 2019
@thomasvl
Fix decoding of overencoded booleans.
d0ed756 
if the value was >32bit with the low bits all being zero, it was decoded as
false instead of as true.

Fixes protocolbuffers#6863
@thomasvl thomasvl mentioned this issue Nov 8, 2019
Merged
@thomasvl
Copy link
Contributor

thomasvl commented Nov 8, 2019

Patched your change in locally, fix is right, #6866 out for testing on kokoro.

@rafi-kamal
Copy link
Contributor Author

Thank you!

thomasvl added a commit that referenced this issue Nov 8, 2019
@thomasvl
Fix decoding of overencoded booleans.
668eb3b 
if the value was >32bit with the low bits all being zero, it was decoded as
false instead of as true.

Fixes #6863
@thomasvl
Copy link
Contributor

thomasvl commented Nov 8, 2019

Landed the fix.

nlhien pushed a commit to nlhien/protobuf that referenced this issue Feb 28, 2020
@thomasvl @nlhien
Fix decoding of overencoded booleans.
d58de59 
if the value was >32bit with the low bits all being zero, it was decoded as
false instead of as true.

Fixes protocolbuffers#6863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasvl thomasvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix decoding of overencoded booleans. thomasvl/protobuf
2 participants
@rafi-kamal @thomasvl