Breaking Change: Stop generating the "newInstance" method. This is no…

…t used anymore. PiperOrigin-RevId: 600123108
protocolbuffers · Jan 20, 2024 · c0d08bd · c0d08bd
1 parent 1eff9d7
commit c0d08bd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/java/core/src/main/java/com/google/protobuf/NewInstanceSchemaFull.java b/java/core/src/main/java/com/google/protobuf/NewInstanceSchemaFull.java
@@ -10,7 +10,6 @@
 final class NewInstanceSchemaFull implements NewInstanceSchema {
   @Override
   public Object newInstance(Object defaultInstance) {
-    return ((GeneratedMessage) defaultInstance)
-        .newInstance(GeneratedMessage.UnusedPrivateParameter.INSTANCE);
+    return ((Message) defaultInstance).toBuilder().buildPartial();
   }
 }
diff --git a/src/google/protobuf/compiler/java/message.cc b/src/google/protobuf/compiler/java/message.cc
@@ -357,15 +357,6 @@ void ImmutableMessageGenerator::Generate(io::Printer* printer) {
       "}\n"
       "\n");
 
-  printer->Print(variables,
-                 "@java.lang.Override\n"
-                 "@SuppressWarnings({\"unused\"})\n"
-                 "protected java.lang.Object newInstance(\n"
-                 "    UnusedPrivateParameter unused) {\n"
-                 "  return new $classname$();\n"
-                 "}\n"
-                 "\n");
-
   GenerateDescriptorMethods(printer);
 
   // Nested types