Skip to content

Commit

Permalink
Updated upb dep to the latest 23.x commit. (#13043)
Browse files Browse the repository at this point in the history
* Updated upb dep to the latest 23.x commit.

* Updated upb dep to the latest 23.x commit.
  • Loading branch information
ericsalo authored Jun 13, 2023
1 parent f5efaf9 commit bea53aa
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions php/ext/google/protobuf/php-upb.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,9 +518,9 @@ upb_MapInsertStatus upb_Map_Insert(upb_Map* map, upb_MessageValue key,

bool upb_Map_Delete(upb_Map* map, upb_MessageValue key, upb_MessageValue* val) {
upb_value v;
const bool ok = _upb_Map_Delete(map, &key, map->key_size, &v);
if (val) val->uint64_val = v.val;
return ok;
const bool removed = _upb_Map_Delete(map, &key, map->key_size, &v);
if (val) _upb_map_fromvalue(v, val, map->val_size);
return removed;
}

bool upb_Map_Next(const upb_Map* map, upb_MessageValue* key,
Expand Down
4 changes: 2 additions & 2 deletions protobuf_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def protobuf_deps():
_github_archive(
name = "upb",
repo = "https://github.com/protocolbuffers/upb",
commit = "e8161b8d42d057a95cf38ea7bce223f84f24a656",
sha256 = "8de5c7e3210687fcea2d0a18e1ba1bca1f1f3a042e1f0bac06d93a12391c0050",
commit = "1956df14832979471d0c79210a817aeb54f7a526",
sha256 = "102039feae921205690d28561d6c74ba13e0561a76d7247de5df7d7cc8d72ca6",
patches = ["@com_google_protobuf//build_defs:upb.patch"],
)
6 changes: 3 additions & 3 deletions ruby/ext/google/protobuf_c/ruby-upb.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,9 +518,9 @@ upb_MapInsertStatus upb_Map_Insert(upb_Map* map, upb_MessageValue key,

bool upb_Map_Delete(upb_Map* map, upb_MessageValue key, upb_MessageValue* val) {
upb_value v;
const bool ok = _upb_Map_Delete(map, &key, map->key_size, &v);
if (val) val->uint64_val = v.val;
return ok;
const bool removed = _upb_Map_Delete(map, &key, map->key_size, &v);
if (val) _upb_map_fromvalue(v, val, map->val_size);
return removed;
}

bool upb_Map_Next(const upb_Map* map, upb_MessageValue* key,
Expand Down

0 comments on commit bea53aa

Please sign in to comment.