Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: simplify, regenerate es6 too #733

Closed
wants to merge 1 commit into from
Closed

scripts: simplify, regenerate es6 too #733

wants to merge 1 commit into from

Conversation

tamird
Copy link

@tamird tamird commented Mar 27, 2017

Ran into this while trying to investigate #732.

@dcodeIO
Copy link
Member

dcodeIO commented Mar 27, 2017

Looks good, but could you maybe update the PR so that it only changes the generator script? For instance, google/protobuf/descriptor.json is intentionally missing the redundant options keys.

@tamird
Copy link
Author

tamird commented Mar 27, 2017

What do you mean? Would you like me to modify gencommon to omit empty options?

@dcodeIO dcodeIO closed this in 2c2d400 Mar 31, 2017
@tamird tamird deleted the fix-aliases branch March 31, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants