Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore "duplicate name" errors on pbjs #501

Closed
wants to merge 2 commits into from
Closed

ignore "duplicate name" errors on pbjs #501

wants to merge 2 commits into from

Conversation

endel
Copy link
Contributor

@endel endel commented Nov 29, 2016

Scenario:

When I try to generate a bundle.json from multiple proto files that require the same dependency, I get "duplicate name" exception. See below.

file1.proto

import "common.proto"

file2.proto

import "common.proto"

Command:

pbjs file1.proto file2.proto 

Outputs:

Error: duplicate name '...' in Namespace

@dcodeIO
Copy link
Member

dcodeIO commented Nov 29, 2016

Will look into this. Can't accept the PR when it just removes a valid error.

@dcodeIO dcodeIO closed this in 3c16e46 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants