-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove eval usage so that chrome extension MV3 can run properly #1941
Conversation
Sorry for disturbing. I'm willing to push the progress. |
Helo, @AntiMoron do you have any updates on this issue? |
No, I think I've done the coding & testing part, now I'm looking for core members to merge. Thanks for supporting! |
Hi, is there anything what we can do to fix this issue/ merge this request? Thanks! |
Hi, it has been a month since the code commited. The code has been thoroughly reviewed and is clean and easy to verify. I kindly request your attention to address this matter at your earliest convenience. |
anyone with write access spend sometime on reviewing this? |
Update on this one? |
Sadly, still waiting for someone to review this. |
Still waiting on this!! |
any updates here? |
any updates ?? |
I'm going to fork it, I can't stand it anymore. The repository owner seems unwilling to accept any changes, right? |
@ZhangZekun I think so. @dcodeIO He's just there. No offense, I just checked his profile, yes, he's been commiting constantly during past months. This fix should be fine, please merge and pub an alpha version? |
any news? this eval must go please |
I can merge this one but we'll need to ask @sofisl or someone else from Google with release access to coordinate the release and actually release it. If there's some other fixes that need to be taken care of we could do it too. Note: I don't work with anything related to protobuf.js anymore, might find some time on regular maintenance and merging PRs like this one but don't want to make releases because it normally requires more testing (with Google libraries) that I can realistically handle. |
@alexander-fenster You are a savior!!! |
AS POST TITLE.
I think this can be published as an alpha version for more tests.