Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove eval usage so that chrome extension MV3 can run properly #1941

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

AntiMoron
Copy link
Contributor

AS POST TITLE.

I think this can be published as an alpha version for more tests.

@AntiMoron
Copy link
Contributor Author

The latest Chrome(currently 118.0.5993.117) is blocking js that contains 'eval' now, which may result in blank screen.

image

@AntiMoron
Copy link
Contributor Author

Sorry for disturbing. I'm willing to push the progress.

@dcodeIO
@alexander-fenster
@bcoe

@AntiMoron
Copy link
Contributor Author

AntiMoron commented Oct 31, 2023

Let's see how ChatGPT judge it:

image

image

image

@butoramatus
Copy link

Helo, @AntiMoron do you have any updates on this issue?
@dcodeIO @alexander-fenster @bcoe do you plan to move this forward?
Thank you!

@AntiMoron
Copy link
Contributor Author

Helo, @AntiMoron do you have any updates on this issue? @dcodeIO @alexander-fenster @bcoe do you plan to move this forward? Thank you!

No, I think I've done the coding & testing part, now I'm looking for core members to merge. Thanks for supporting!

@TvojTatk0
Copy link

Hi, is there anything what we can do to fix this issue/ merge this request?
It starts to become a real issue for us.

Thanks!

@Jennal
Copy link

Jennal commented Nov 20, 2023

Hi, it has been a month since the code commited. The code has been thoroughly reviewed and is clean and easy to verify. I kindly request your attention to address this matter at your earliest convenience.

@AntiMoron
Copy link
Contributor Author

anyone with write access spend sometime on reviewing this?
@dcodeIO
@robin-anil @murgatroid99 @JustinBeckwith

@emillime
Copy link

Update on this one?

@AntiMoron
Copy link
Contributor Author

Update on this one?

Sadly, still waiting for someone to review this.

@LivingstonPradeep
Copy link

Still waiting on this!!

@graham-atom
Copy link

any updates here?

@graham-atom
Copy link

@alexander-fenster

@zhanzekun
Copy link

any updates ??

@zhanzekun
Copy link

I'm going to fork it, I can't stand it anymore. The repository owner seems unwilling to accept any changes, right?

@AntiMoron
Copy link
Contributor Author

@ZhangZekun I think so.

@dcodeIO He's just there. No offense, I just checked his profile, yes, he's been commiting constantly during past months.

image

This fix should be fine, please merge and pub an alpha version?

@GG-Creations
Copy link

any news? this eval must go please

@alexander-fenster
Copy link
Contributor

I can merge this one but we'll need to ask @sofisl or someone else from Google with release access to coordinate the release and actually release it. If there's some other fixes that need to be taken care of we could do it too.

Note: I don't work with anything related to protobuf.js anymore, might find some time on regular maintenance and merging PRs like this one but don't want to make releases because it normally requires more testing (with Google libraries) that I can realistically handle.

@alexander-fenster alexander-fenster merged commit f2ccb99 into protobufjs:master Dec 30, 2024
6 checks passed
@AntiMoron
Copy link
Contributor Author

@alexander-fenster You are a savior!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.