Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encode/decode delimited gencode #1093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hellraisercenobit
Copy link

No description provided.

@alexander-fenster
Copy link
Contributor

Hi @hellraisercenobit,

Can you please add some description of what you're trying to achieve here? It's unclear for me from the code.

Thanks!

@hellraisercenobit
Copy link
Author

hellraisercenobit commented Jun 25, 2019

Hello @alexander-fenster !
Gencode was buggy with encode/decode delimited methods.
encode/decode with multiple fragments was KO.
single fragment was OK.

My fix is just a report of original code into gencode provided by protobuf itself ;)
This PR was already merged a long time ago ^^.

@nihohit
Copy link

nihohit commented Feb 26, 2023

@alexander-fenster can this be reviewed, please?
We see this issue in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants