Add log status at the bottom #734
Conversation
so long the scroll position is at the very bottom
yellow is not visible well on the light background
so that can be read without scrolling
- log opens by clicking on the log icon - the icon changes if warning / error appears in log - the last warning / error is shown in the tooltip - the icon clears on mouse click (which opens the log)
to make it more clear that an error / warning may be not just one
1. log is displayed in JTextPane not in JList advantages: - no custom code for rendering - rendering is much fast (previously the whole JList layout was re-calculated every time a message is appended) - (parts of) messages are now easy to copy / paste 2. Use the native logback PatternLayout to format messages based on a format string - it is more flexible and easy to configure
|
I now have changed the implementation of the log window to use JTextPane instead of JList. Was there any deep reason to display the log in a list? |
including settings of: - the line wrap - the character limit - the log level - the log pattern - the foreground colors of messages
|
@matthewhorridge would you consider merging this pull request before the new release of Protege? It is essential for the new version of ELK. |
|
@ykazakov sorry for not looking at this sooner. Will take a look asap. I might target this for beta-4 if that's okay. |
|
beta-4 is ok, just wanted to be sure it is a part of the next Protege (non-beta) release |
|
Excellent job with this @ykazakov. Big improvement. The only thing that bothers me is the removal of the View log menu item. |
|
Merged in. I've added the menu item back so that it's accessible from the menu. |
|
Thanks for merging! I don't mind putting the menu back. It is probably a good idea as novice users might not notice the log icon. |
|
I've put the menu back in. I think the timestamp button is better where it is. Overall, this is a great improvement... very nice UI work! |
|
I see. Thanks. Just downloaded the new version. Checking... The tooltip for the menu Window > Show Log... is the same as for Timestamp log / console. Probably copy & paste error. |
|
Other than that looks good. Thanks again for merging! |
The changes add a log icon at the bottom of Protege window.
This icon can be used to monitor problems (warnings and errors) and quickly open the log.
Previously this has been handled only for errors (an error icon showed at the top) but the user was uninformed about the warnings (unless a log window is already opened). However, warnings are also important. E.g., a reasoner (like ELK) warns when the result is incomplete (see, e.g., #710), which could stay unnoticed.