Fallback to OS-independent file-saving dialog on macOS #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, if we don't get a File from the macOS-specific MacUIUtil#saveFile() method, assume this is due to a failure of that method (or of the underlying JRE) to even show the native file-choosing dialog (as was shown to happen, #1106), and fallback to the OS-independent method. This allow users affected by the "never-showing-native-dialog" bug to still save their files, at the price of asking users not affected by that same bug to click "cancel" on two consecutive dialogs if they do want to cancel the save operation at the file-choosing step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a workaround for the file-saving issue reported in #1106.
On macOS, if we don’t get a File from the macOS-specific
MacUIUtil#saveFile()method, we assume this is due to a failure of that method (or of the underlying JRE) to even show the native file-choosing dialog (as was shown to happen in #1106), and we fallback to the OS-independent method instead of aborting the file-saving operation entirely.This allow users affected by the “never-showing-native-dialog“ bug to still save their files, at the price of asking users not affected by that same bug to click “cancel” on two consecutive dialogs if they do want to cancel the save operation at the file-choosing step.