-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prospector 1.10.2 does not support with_mypy
optional tool [in conda]
#624
Comments
Try using (See similar issues like #618) Honestly I think it's a bit irritating and I might move away from poetry for packaging, or rename optional extras or something. |
(Also the conda packaging is not something I am familiar with so I have no idea what black magic might go on there too.) |
Blast! It works well with |
with_mypy
optional toolwith_mypy
optional tool [in conda]
I think it'd be good to get around to having "first-party" support for conda packaging as there are often conda-related bugs which turn out to be due to someone else packaging it in a way I don't understand or know about! |
a migration to a conda-forge/Mambaforge environment file to hold all the dependencies, see eg one here - that may allow for PyPI-only packages (even if it's not optimal, and we'd have to nudge those maintainers to package their packages for conda-forge) would prob do better for you IMO - Of course there are issues with dependencies on conda-forge being improperly built at times, but most of these are detected early (by others too), so are easily fixable. Plus, this way it's really easy to have Github Actions tests that run env building and installation of your package and test the different modules etc |
@valeriupredoi is this issue still valid? We can't go back and fix old versions, but what about the latest? |
all good @carlio many thanks for the reminder, I should have closed it after #624 (comment) 🍺 |
Hi @carlio long time no see (on GH), hope you doing good, mate! I ran into this little nugget just now:
It seems that
with_mypy
is not playing well with the latest prospector for some reason. I checked the package on conda-feedstock (I had previously approved the upgrade version PR from the bot, a few weeks ago) and the package specs are alright wrt mypy, but there's some oddity in poetry perhaps? Cheers, let me know if I can help 🍺The text was updated successfully, but these errors were encountered: