Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mark view #103

Merged
merged 38 commits into from
Dec 19, 2024
Merged

feat: support mark view #103

merged 38 commits into from
Dec 19, 2024

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Nov 28, 2024

This PR implements mark view support for core and react.

@ocavue ocavue mentioned this pull request Nov 28, 2024
@ocavue ocavue requested a review from Saul-Mirone November 28, 2024 12:35
@ocavue ocavue marked this pull request as ready for review November 28, 2024 12:42
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

pkg-pr-new bot commented Dec 4, 2024

Open in Stackblitz

@prosemirror-adapter/core

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/core@103

@prosemirror-adapter/lit

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/lit@103

@prosemirror-adapter/solid

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/solid@103

@prosemirror-adapter/react

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/react@103

@prosemirror-adapter/svelte

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/svelte@103

@prosemirror-adapter/vue

npm i https://pkg.pr.new/prosekit/prosemirror-adapter/@prosemirror-adapter/vue@103

commit: 515f375

@Saul-Mirone
Copy link
Collaborator

Could you please also update the readme here?

- [x] [Prosemirror Node View](https://prosemirror.net/docs/ref/#view.NodeView)
- [x] [Prosemirror Plugin View](https://prosemirror.net/docs/ref/#state.PluginView)
- [x] [Prosemirror Widget Decoration](https://prosemirror.net/docs/ref/#view.Decoration%5Ewidget)

@Saul-Mirone
Copy link
Collaborator

Feel free to merge the pr if you think it's ready.

@ocavue ocavue merged commit 473af64 into main Dec 19, 2024
4 checks passed
@ocavue ocavue deleted the ocavue/markview-v4 branch December 19, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants