Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal ID for messages #98

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Use internal ID for messages #98

merged 3 commits into from
Aug 29, 2024

Conversation

nesium
Copy link
Contributor

@nesium nesium commented Aug 2, 2024

Todo:

  • Recognize duplicate messages and update them if needed instead of inserting them as a new message (1)
  • Introduce MessagingDomainService and move message sending/receiving code there as well as duplicate detection
  • Fix tests

(1) See:

@nesium nesium linked an issue Aug 2, 2024 that may be closed by this pull request
@nesium nesium force-pushed the internal-message-id branch from 31b5a99 to 924f974 Compare August 22, 2024 10:05
@nesium nesium force-pushed the internal-message-id branch 2 times, most recently from 6cf8442 to e50ca87 Compare August 28, 2024 17:48
@nesium nesium force-pushed the internal-message-id branch from e50ca87 to 02564a7 Compare August 29, 2024 10:41
@nesium nesium marked this pull request as ready for review August 29, 2024 10:41
@nesium nesium merged commit 6f648cf into master Aug 29, 2024
2 checks passed
@nesium nesium deleted the internal-message-id branch August 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages disappear due to reliance on message ids
1 participant