Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface panics in Wasm binary #144

Open
nesium opened this issue Sep 12, 2024 · 0 comments
Open

Surface panics in Wasm binary #144

nesium opened this issue Sep 12, 2024 · 0 comments
Assignees
@valeriansaliou
Labels
enhancement New feature or request

Comments

@nesium
Copy link
Contributor

nesium commented Sep 12, 2024

It would be tremendously helpful for debugging to surface Rust panics in the Wasm binary to the user. The messages sent to the JS code include stacktraces and that way users could just copy the error message and send it to us. Ideally the message would be sent to some error recording service like Bugsnag or the like.

Obviously the goal is to never see them since panics should never happen. Until this is the case it would be good however to surface them prominently.

Loosely refs #143.
nesium added a commit to prose-im/prose-core-client that referenced this issue Sep 12, 2024
@nesium
feat(sdk-js): Log panics to a separate method in JSLogger
16688e9 
refs prose-im/prose-app-web#144
nesium added a commit that referenced this issue Sep 12, 2024
@nesium
chore: Add method to log panic
ed7d181 
refs #144
@valeriansaliou valeriansaliou self-assigned this Sep 17, 2024
@valeriansaliou valeriansaliou added the enhancement New feature or request label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriansaliou valeriansaliou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nesium @valeriansaliou