Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature = "cargo-clippy" deprecation #429

Merged
merged 1 commit into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proptest/src/arbitrary/_alloc/collections.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Arbitrary implementations for `std::collections`.

//#![cfg_attr(feature="cargo-clippy", allow(implicit_hasher))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just dead code? can probably remove this but won't block getting the fix in.

//#![cfg_attr(clippy, allow(implicit_hasher))]

//==============================================================================
// Imports:
Expand Down
4 changes: 2 additions & 2 deletions proptest/src/arbitrary/_core/cell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ wrap_from!(UnsafeCell);

lazy_just!(BorrowError, || {
// False positive:
#[cfg_attr(feature = "cargo-clippy", allow(let_and_return))]
#[cfg_attr(clippy, allow(let_and_return))]
{
let _rc = RefCell::new(());
let _bm = _rc.borrow_mut();
Expand All @@ -28,7 +28,7 @@ lazy_just!(BorrowError, || {
});
lazy_just!(BorrowMutError, || {
// False positive:
#[cfg_attr(feature = "cargo-clippy", allow(let_and_return))]
#[cfg_attr(clippy, allow(let_and_return))]
{
let _rc = RefCell::new(());
let _bm = _rc.borrow_mut();
Expand Down
2 changes: 1 addition & 1 deletion proptest/src/bits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ use crate::strategy::*;
use crate::test_runner::*;

/// Trait for types which can be handled with `BitSetStrategy`.
#[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))]
#[cfg_attr(clippy, allow(len_without_is_empty))]
pub trait BitSetLike: Clone + fmt::Debug {
/// Create a new value of `Self` with space for up to `max` bits, all
/// initialised to zero.
Expand Down
2 changes: 1 addition & 1 deletion proptest/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#![forbid(future_incompatible)]
#![deny(missing_docs, bare_trait_objects)]
#![no_std]
#![cfg_attr(feature = "cargo-clippy", allow(
#![cfg_attr(clippy, allow(
doc_markdown,
// We have a lot of these lints for associated types... And we don't care.
type_complexity
Expand Down
2 changes: 1 addition & 1 deletion proptest/src/option.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Strategies for generating `std::Option` values.

#![cfg_attr(feature = "cargo-clippy", allow(expl_impl_clone_on_copy))]
#![cfg_attr(clippy, allow(expl_impl_clone_on_copy))]

use core::fmt;
use core::marker::PhantomData;
Expand Down
2 changes: 1 addition & 1 deletion proptest/src/result.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
//! "maybe err" since the success case results in an easier to understand code
//! path.

#![cfg_attr(feature = "cargo-clippy", allow(expl_impl_clone_on_copy))]
#![cfg_attr(clippy, allow(expl_impl_clone_on_copy))]

use core::fmt;
use core::marker::PhantomData;
Expand Down
Loading