Fixes phpstan errors, set PHPStan to level 7 #1951
Conversation
dereuromark
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
============================================
- Coverage 88.63% 88.56% -0.08%
- Complexity 8019 8051 +32
============================================
Files 243 243
Lines 24549 24592 +43
============================================
+ Hits 21759 21779 +20
- Misses 2790 2813 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mringler This would then be the last PR merged for the release of new beta this week |
|
Nice work! |
| @@ -976,7 +976,7 @@ protected static function getRefRelatedBySuffix(ForeignKey $fk): string | |||
| $localColumnName = $localColumn->getPhpName(); | |||
| $localTable = $fk->getTable(); | |||
| if (!$localColumnName) { | |||
| throw new RuntimeException(sprintf('Could not fetch column: %s in table %s.', $localColumnName, $localTable->getName())); | |||
| throw new RuntimeException(sprintf('Could not fetch column of table %s.', $localTable->getName())); | |||
There was a problem hiding this comment.
Same as above, should the if move up?
Awesome! |
|
Also, only 981 errors more to go for level 8 then :P |
Is this a note to be a volunteer? :P |
PHP Stan fixes for #1921