Skip to content
This repository has been archived by the owner on May 30, 2019. It is now read-only.

Hardcoded invalid dataset location in the npm dist #375

Closed
thefill opened this issue Mar 16, 2018 · 3 comments
Closed

Hardcoded invalid dataset location in the npm dist #375

thefill opened this issue Mar 16, 2018 · 3 comments
Assignees
Milestone

Comments

@thefill
Copy link

thefill commented Mar 16, 2018

It seems like your build script for dist package is messing with paths.

"propel@3.2.0" from npm contains lots of lines like this one:

var __dirname = "/Users/rld/src/propel/src";

Which causes errors when loading datasets.

@brandly
Copy link

brandly commented Mar 16, 2018

can confirm.

const { dataset } = require('propel')
dataset('mnist/train')
Using DL backend.
(node:27781) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/Users/rld/src/propel/deps/data/mnist/train-images-idx3-ubyte'
    at Object.fs.openSync (fs.js:646:18)
    at fs.readFileSync (fs.js:551:33)
    at i (/home/paperspace/js/node_modules/propel/propel.js:107:1529)
    at Object.u [as fetchArrayBuffer] (/home/paperspace/js/node_modules/propel/propel.js:107:1648)
    at i (/home/paperspace/js/node_modules/propel/propel.js:143:583)
    at Object.s [as loadSplit] (/home/paperspace/js/node_modules/propel/propel.js:143:478)
    at mnist/train (/home/paperspace/js/node_modules/propel/propel.js:145:339)
    at o (/home/paperspace/js/node_modules/propel/propel.js:145:450)
    at Object.<anonymous> (/home/paperspace/js/dataset.js:2:1)
    at Module._compile (module.js:652:30)

@ry
Copy link
Contributor

ry commented Mar 16, 2018

Yes this is a bug - thanks for the report. Will fix soon.

@piscisaureus piscisaureus added this to the v3.3.0 milestone Mar 20, 2018
ry added a commit that referenced this issue Mar 22, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 23, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 23, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 23, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 23, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 23, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 24, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 24, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
ry added a commit that referenced this issue Mar 26, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
@ry ry closed this as completed in #425 Mar 26, 2018
ry added a commit that referenced this issue Mar 26, 2018
And ensure datasets reference propelml.org URLs, not filesystem paths.

Fixes #375
@ry
Copy link
Contributor

ry commented Mar 28, 2018

@thefill @brandly It's taken a while, but we've finally cut a new release (v3.3.1) and it should work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants