Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust paths in package.json #1

Merged
merged 3 commits into from
Feb 3, 2023
Merged

fix: adjust paths in package.json #1

merged 3 commits into from
Feb 3, 2023

Conversation

r0binary
Copy link
Contributor

@r0binary r0binary commented Feb 2, 2023

WHAT

  • adjust paths for exports, main, module and types in package.json

WHY

  • the paths do not match the actual file structure making the package unusable

proohit and others added 3 commits December 23, 2022 14:40
**WHAT**
- adjust paths for exports, main, module and types
  in package.json

**WHY**
- the paths do not match the actual file structure
  making the package unusable
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@proohit
Copy link
Owner

proohit commented Feb 3, 2023

Hey, thanks for your request! The declarations in the package json match the exported files after running npm run build. Which problems do you face after installing?

Edit: Ah now I see the issue. That should do the trick, thanks!

@proohit proohit changed the base branch from master to develop February 3, 2023 09:07
@r0binary
Copy link
Contributor Author

r0binary commented Feb 3, 2023

I created a new project and installed netcup-node@0.0.12 from npmjs.com. When I required the package in my code I got unresolved reference errors. After taking a look I stumbled over the mismatching paths in package.json which vanished with the proposed changes.

I attached a screenshot of the file structure as seen on npmjs.com:
grafik

@codecov-commenter
Copy link

Codecov Report

Merging #1 (a00f167) into develop (b2e4134) will not change coverage.
The diff coverage is n/a.

❗ Current head a00f167 differs from pull request most recent head ae69ab7. Consider uploading reports for the commit ae69ab7 to get more accurate results

@@            Coverage Diff            @@
##           develop        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          100       100           
  Branches        14        14           
=========================================
  Hits           100       100           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@proohit proohit merged commit f21c9d8 into proohit:develop Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants