fix(Gitlab): slug_regex when url has different host #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandoAssuncao
changed the title
ashkulz
approved these changes
Apr 4, 2022
|
Thanks for the contribution, @ArmandoAssuncao! Sorry for the late review. |
|
@ArmandoAssuncao can you make a change as per the rubocop failure? |
ArmandoAssuncao
force-pushed
the
fix/slug_regex_with_different_host
branch
from
fae60ca to
d7cbfe8
Compare
|
@ashkulz fixed |
ashkulz
reviewed
Apr 4, 2022
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the host of runner in Gitlab can be different of
api_endpoint.A example:
api_endpointishttps://gitlab.com/api/v4https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/group/x/y/z.gitthe difference is in
gitlab.comandgitlab.netThis PR treat when hosts are differents.