-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more complex yaml structure and fix readme #10
Conversation
Can you check why the tests are failing? |
@ashkulz I patched up the tests b5e8e78 they are all passing now. Something must have changed in Aspell itself because I think when you first made the tests the suggestions it returned were full of whitespaces and simply different to what it returns now. Anyway, this had nothing to do with the current PR's main concerns, it would have failed with or without the Please approve this one when you find the time. Cheers, Khalil |
@ashkulz did you have chance to look at this? |
I'm not sure why there's no checks from GitHub Actions? |
@khalilgharbaoui can you rebase/merge with |
@ashkulz all green |
Release created and pushed to RubyGems, thanks for your contribution! |
I added
.flatten
to the array ofignored_words
andonly_lines_matching
.This way we can have a more complex YAML structure and do things like:
This won't change anything in the behavior of the gem and will just result in better native YAML support.
The final list would look like:
Please consider merging this?