Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more complex yaml structure and fix readme #10

Merged
merged 5 commits into from
Dec 30, 2021

Conversation

khalilgharbaoui
Copy link
Contributor

@khalilgharbaoui khalilgharbaoui commented Mar 22, 2021

I added .flatten to the array of ignored_words and only_lines_matching.

This way we can have a more complex YAML structure and do things like:

able_words: &able_words
  - available
  - considerable
  - unable
  
. . . 
ignored_words:
  - *able_words
  - ignoreme
  - measwell
. . . 

This won't change anything in the behavior of the gem and will just result in better native YAML support.
The final list would look like:

. . .
ignored_words:
  - available
  - considerable
  - unable
  - ignoreme
  - measwell
. . .

Please consider merging this?

@khalilgharbaoui khalilgharbaoui requested a review from a team as a code owner March 22, 2021 02:24
@khalilgharbaoui khalilgharbaoui changed the title Fix readme because It only works with yml Allow more complex yaml structure and fix readme Apr 23, 2021
@ashkulz
Copy link
Member

ashkulz commented May 4, 2021

Can you check why the tests are failing?

@khalilgharbaoui
Copy link
Contributor Author

khalilgharbaoui commented Aug 4, 2021

Can you check why the tests are failing?

afbeelding

@ashkulz I patched up the tests b5e8e78 they are all passing now. Something must have changed in Aspell itself because I think when you first made the tests the suggestions it returned were full of whitespaces and simply different to what it returns now.

Anyway, this had nothing to do with the current PR's main concerns, it would have failed with or without the flatten of arrays I added.

Please approve this one when you find the time.

Cheers,

Khalil

@khalilgharbaoui
Copy link
Contributor Author

@ashkulz did you have chance to look at this?

@ashkulz
Copy link
Member

ashkulz commented Dec 22, 2021

I'm not sure why there's no checks from GitHub Actions?

@ashkulz
Copy link
Member

ashkulz commented Dec 22, 2021

@khalilgharbaoui can you rebase/merge with master so that the build status can be checked? I cherry-picked your test fix as 00a50d3.

@khalilgharbaoui
Copy link
Contributor Author

khalilgharbaoui commented Dec 30, 2021

@ashkulz all green :shipit: pls

@ashkulz ashkulz merged commit ff47c9a into prontolabs:master Dec 30, 2021
@ashkulz
Copy link
Member

ashkulz commented Dec 30, 2021

Release created and pushed to RubyGems, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants