Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateways / payment methods input fields API 🔁2️⃣ #336

Closed
2 of 4 tasks
remcotolsma opened this issue Sep 5, 2022 · 4 comments
Closed
2 of 4 tasks

Gateways / payment methods input fields API 🔁2️⃣ #336

remcotolsma opened this issue Sep 5, 2022 · 4 comments
Assignees

Comments

@remcotolsma
Copy link
Member

remcotolsma commented Sep 5, 2022

  • Add support for OmniKassa and AfterPay.nl gender and birthdate field.
  • Remove IDealIssuerSelectField class, just use general SelectField class?
  • Add support for Mollie direct debit and bank account name and IBAN field.
  • Work on unique HTML id and name attributes.

Source: #154 (comment)

@remcotolsma remcotolsma moved this to Todo in Pronamic Pay Sep 5, 2022
@remcotolsma remcotolsma changed the title Gateways / payment methods input fields API (iteration 2) Gateways / payment methods input fields API 🔁2️⃣ Sep 5, 2022
rvdsteege added a commit to pronamic/wp-pronamic-pay-mollie that referenced this issue Sep 6, 2022
rvdsteege added a commit to pronamic/wp-pay-core that referenced this issue Sep 6, 2022
@rvdsteege
Copy link
Member

Remove IDealIssuerSelectField class, just use general SelectField class?

We might want to do something with last used issuer etc., would a specific IDealIssuerSelectField class not make that easier to accomplish (if we are going to map the issuers to a core constant)?

@remcotolsma
Copy link
Member Author

remcotolsma commented Sep 12, 2022

Yes, but i don't think it's good practice that it requires a subclass. We could also use an id or type property to identify specific fields:

  • ideal_issuer
  • gender
  • date_of_birth
  • etc.

rvdsteege added a commit to pronamic/wp-pronamic-pay-rabo-smart-pay that referenced this issue Sep 12, 2022
rvdsteege added a commit to pronamic/wp-pronamic-pay-woocommerce that referenced this issue Sep 12, 2022
rvdsteege added a commit to pronamic/wp-pay-core that referenced this issue Sep 12, 2022
@rvdsteege
Copy link
Member

rvdsteege commented Sep 19, 2022

Todo for 'Add support for OmniKassa and AfterPay.nl gender and birthdate field':

  • Test/fix gender and date of birth fields with WooCommerce blocks
  • Test with plugin settings for WooCommerce checkout gender and date of birth fields enabled

rvdsteege added a commit to pronamic/wp-pronamic-pay-woocommerce that referenced this issue Sep 22, 2022
rvdsteege added a commit to pronamic/wp-pronamic-pay-rabo-smart-pay that referenced this issue Sep 22, 2022
rvdsteege added a commit to pronamic/wp-pronamic-pay-woocommerce that referenced this issue Sep 22, 2022
@remcotolsma
Copy link
Member Author

For now, we are satisfied with the current implementation.

@github-project-automation github-project-automation bot moved this from Todo to Done in Pronamic Pay Feb 14, 2023
@remcotolsma remcotolsma self-assigned this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants