Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wp-pay* packacges in packages? #3

Closed
remcotolsma opened this issue Feb 23, 2023 · 2 comments
Closed

Install wp-pay* packacges in packages? #3

remcotolsma opened this issue Feb 23, 2023 · 2 comments

Comments

@remcotolsma
Copy link
Member

"wp-pay-extensions/contact-form-7": "^3.2",
"wp-pay-gateways/mollie": "^4.7",
"wp-pay/core": "^4.7"

Reverse of:

That way these strings will be picked up by https://translate.wordpress.org/projects/wp-plugins/pronamic-pay-with-mollie-for-contact-form-7/stable/nl/default/.

@remcotolsma
Copy link
Member Author

I'm not sure this is possible: https://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.mdhttps://github.com/composer/installers#current-supported-package-types.

Should we allow dynamic package types or paths? No

What are they? The ability for a package author to determine where a package
will be installed either through setting the path directly in their
composer.json or through a dynamic package type: "type": "framework-install-here".

It has been proposed many times. Even implemented once early on and then
removed. Installers won't do this because it would allow a single package
author to wipe out entire folders without the user's consent. That user would
then come here to yell at us.

Anyone still wanting this capability should consider requiring https://github.com/oomphinc/composer-installers-extender.

We could (ab)use the wordpress-plugin type?

rvdsteege added a commit to pronamic/wp-pronamic-pay-contact-form-7 that referenced this issue Mar 6, 2023
rvdsteege added a commit to pronamic/wp-pronamic-pay-mollie that referenced this issue Mar 6, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Pronamic Pay Mar 6, 2023
@rvdsteege
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants