Delayed actions feeds not processed during fulfilment of free payments #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Gravity Forms entry results in a free payment, for example through discount, the delayed actions of the payment feed are not processed during fulfilment. The
Extension::fulfill_order( $entry )is called correctly for this entry and$addon->maybe_process_feed( $entry, $form )too.However, because we add the
gform_is_delayed_pre_process_feed_{form_id}hook inProcessor::add_hooks(), the feed does not actually get processed.This PR removes the added filter to delay processing of the feed if the payment status is set early on to 'Success', because there is no amount to be paid. In this case, the successful payment notification will be send, the entry payment status will be updated to 'Paid', so I think the delayed feed should also be processed.