Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of feedback_args #8

Merged
merged 9 commits into from
Feb 23, 2023
Merged

Getting rid of feedback_args #8

merged 9 commits into from
Feb 23, 2023

Conversation

rvdsteege
Copy link
Member

Fix #7.

@rvdsteege
Copy link
Member Author

@remcotolsma as discussed at HQ, I've made the following changes:

  1. always filter the submission result;
  2. use values from submission result in mail tags, so we could also remove the private $payment property.

@remcotolsma remcotolsma merged commit 631888a into develop Feb 23, 2023
@remcotolsma remcotolsma deleted the issues/7 branch February 23, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcotolsma remcotolsma remcotolsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use $submission->add_result_props( ... ) instead of feedback_args?
2 participants
@rvdsteege @remcotolsma