Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always install, not only in administrative interface pages #179

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Always install, not only in administrative interface pages #179

merged 3 commits into from
Apr 23, 2024

Conversation

remcotolsma
Copy link
Member

No description provided.

@remcotolsma remcotolsma requested a review from rvdsteege April 22, 2024 09:03
@remcotolsma remcotolsma self-assigned this Apr 22, 2024
@remcotolsma remcotolsma linked an issue Apr 22, 2024 that may be closed by this pull request
Installation routine only performed in admin #178
Closed
rvdsteege
rvdsteege requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@rvdsteege rvdsteege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes break all frontends:

Fatal error: Uncaught TypeError: Pronamic\WordPress\Pay\Admin\Install::__construct(): Argument #2 ($admin) must be of type Pronamic\WordPress\Pay\Admin\AdminModule, null given

@remcotolsma
Copy link
Member Author

Did some improvements in e0cfbaa.

@remcotolsma remcotolsma requested a review from rvdsteege April 23, 2024 07:33
rvdsteege
rvdsteege approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@rvdsteege rvdsteege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the pronamic_pay_admin_redirect transient is only set when the plugin is installed/updated through the admin, but I assume that is correct behaviour? The admin module (which has the about page) is only loaded when is_admin().

@rvdsteege rvdsteege changed the title Alway install not only in administrative interface pages Always install, not only in administrative interface pages Apr 23, 2024
@remcotolsma remcotolsma merged commit 6ef9814 into main Apr 23, 2024
20 checks passed
@remcotolsma remcotolsma deleted the 178-installation-routine-only-performed-in-admin branch April 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvdsteege rvdsteege rvdsteege approved these changes

Assignees

@remcotolsma remcotolsma

Labels
None yet
Projects
Pronamic Pay
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation routine only performed in admin
2 participants
@remcotolsma @rvdsteege