Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed view of Redirection and Subscription Pages for Mobile #169

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

knit-pay
Copy link
Contributor

Fixed view of Redirection and Subscription Pages for mobile phones.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e484e55) 22.39% compared to head (3a020e9) 22.39%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #169   +/-   ##
=========================================
  Coverage     22.39%   22.39%           
  Complexity     2526     2526           
=========================================
  Files           106      106           
  Lines         10149    10149           
=========================================
  Hits           2273     2273           
  Misses         7876     7876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcotolsma
Copy link
Member

Thanks.

Before:

Scherm­afbeelding 2024-01-11 om 14 40 15

After:

Scherm­afbeelding 2024-01-11 om 14 40 41

@rvdsteege
Copy link
Member

The card number is not displayed anymore in the after screenshot and the button seems to large? 😕 I think this needs some further attention?

@knit-pay
Copy link
Contributor Author

@rvdsteege @remcotolsma
Thanks for bringing these issues to my notice. I will check this further.

@knit-pay
Copy link
Contributor Author

Hello @rvdsteege and @remcotolsma

Made changes in CSS, and now the button and card number are looking better. Please check.

image

@knit-pay
Copy link
Contributor Author

Hello @rvdsteege and @remcotolsma

had you got chance to review the changes?

@rvdsteege rvdsteege merged commit 4f25fdf into pronamic:main Mar 8, 2024
15 checks passed
@knit-pay
Copy link
Contributor Author

knit-pay commented Mar 9, 2024

Thanks @rvdsteege and @remcotolsma for considering this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants