Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider payment status Reserved? #66

Closed
remcotolsma opened this issue Jun 22, 2022 · 3 comments · Fixed by #68
Closed

Reconsider payment status Reserved? #66

remcotolsma opened this issue Jun 22, 2022 · 3 comments · Fixed by #68
Assignees
@remcotolsma
Labels
help wanted question

Comments

@remcotolsma
Copy link
Member

remcotolsma commented Jun 22, 2022 •
edited by rvdsteege
Loading

In ecd0b07 we added the payment status Reserved. I think this is mainly due to support for Sisow pay later payment methods. We had an internal Basecamp to-do for this at the time:

https://basecamp.com/1810084/projects/10966871/todos/368810841

In pronamic/wp-pronamic-pay-mollie#4 we discovered that Mollie uses a authorized payment / order status.

Is the term authorized more common in combination with capture?
@remcotolsma remcotolsma self-assigned this Jun 22, 2022
@rvdsteege rvdsteege changed the title Reconsider payment status Reversed? Reconsider payment status Reserved? Jun 22, 2022
@rvdsteege
Copy link
Member

Yup, I 100% agree it should be Authorized.

As a side note, we could maybe also change Success (iDEAL) to Paid sometime?

@remcotolsma remcotolsma linked a pull request Jun 27, 2022 that will close this issue
Add new payment status 'Authorized'. #68
Merged
@remcotolsma remcotolsma reopened this Jun 28, 2022
@remcotolsma
Copy link
Member Author

Added new payment status Authorized in #68. Need to deprecate the Reserved payment status.

remcotolsma added a commit that referenced this issue Jun 30, 2022
@remcotolsma
Mark RESERVED as deprecated.
d2fdcb9 
See #66.
remcotolsma added a commit to pronamic/wp-pronamic-pay-easy-digital-downloads that referenced this issue Aug 24, 2022
@remcotolsma
Remove deprecated RESERVED payment status core.
992803b 
pronamic/wp-pay-core#66
remcotolsma added a commit to pronamic/wp-pronamic-pay-woocommerce that referenced this issue Aug 24, 2022
@remcotolsma
Remove deprecated RESERVED payment status code.
6f65221 
pronamic/wp-pay-core#66
@remcotolsma
Copy link
Member Author

Since Sisow is deprecated I removed all Reserved code.

@knit-pay knit-pay mentioned this issue Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remcotolsma remcotolsma

Labels
help wanted question
Projects
Pronamic Pay
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new payment status 'Authorized'. pronamic/wp-pay-core
2 participants
@remcotolsma @rvdsteege