Regarding Cancel Subscription Function

[knit-pay]

I think in the handle_subscription_cancel function, we should call the cancel_subscription function of Gateway also. In some payment gateway, we need to make an API call to inform the gateway that the subscription is canceled. Apart from this, is there any other way to make an API call while executing the handle_subscription_cancel function? Or is there an action similar to pronamic_payment_status_update_ which we can use to execute a function when a subscription gets canceled? Please refer to the code mentioned below.

https://github.com/wp-pay/core/blob/88ac1e26ae754cb2366697023f38f6004dbd15bb/src/Subscriptions/SubscriptionsModule.php#L152

https://github.com/wp-pay/core/blob/88ac1e26ae754cb2366697023f38f6004dbd15bb/src/Core/Gateway.php#L431

[knit-pay]

Hello Team

Is there an update on this?

[rvdsteege]

Seems we don't use (and never have) the Gateway::update_subscription() and Gateway::cancel_subscription() methods ourselves. We might remove these, @remcotolsma?

wp-pay-core/src/Core/Gateway.php

Lines 244 to 262 in f220aa2

	/**
	* Handle subscription update.
	*
	* @param Payment $payment The payment to handle subscription update for.
	* @return void
	*/
	public function update_subscription( Payment $payment ) {
	}
	/**
	* Handle subscription cancellation.
	*
	* @param Subscription $subscription The subscription to handle cancellation for.
	* @return void
	*/
	public function cancel_subscription( Subscription $subscription ) {
	}

@knit-pay you should be able to hook into subscription status updates through the status update actions.

wp-pay-core/src/Subscriptions/SubscriptionsDataStoreCPT.php

Lines 761 to 795 in f220aa2

	/**
	* Subscription status updated for plugin integration source from old to new status.
	*
	* [`{$source}`](https://github.com/pronamic/wp-pronamic-pay/wiki#sources)
	* [`{$old_status}`](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status)
	* [`{$new_status}`](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status)
	*
	* @param Subscription $subscription Subscription.
	* @param bool $can_redirect Flag to indicate if redirect is allowed after the subscription update.
	* @param null|string $previous_status Previous [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	* @param null|string $updated_status Updated [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	*/
	do_action( 'pronamic_subscription_status_update_' . $source . '_' . $old_status . '_to_' . $new_status, $subscription, $can_redirect, $previous_status, $updated_status );
	/**
	* Subscription status updated for plugin integration source.
	*
	* [`{$source}`](https://github.com/pronamic/wp-pronamic-pay/wiki#sources)
	*
	* @param Subscription $subscription Subscription.
	* @param bool $can_redirect Flag to indicate if redirect is allowed after the subscription update.
	* @param null|string $previous_status Previous [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	* @param null|string $updated_status Updated [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	*/
	do_action( 'pronamic_subscription_status_update_' . $source, $subscription, $can_redirect, $previous_status, $updated_status );
	/**
	* Subscription status updated.
	*
	* @param Subscription $subscription Subscription.
	* @param bool $can_redirect Flag to indicate if redirect is allowed after the subscription update.
	* @param null|string $previous_status Previous [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	* @param null|string $updated_status Updated [subscription status](https://github.com/pronamic/wp-pronamic-pay/wiki#subscription-status).
	*/
	do_action( 'pronamic_subscription_status_update', $subscription, $can_redirect, $previous_status, $updated_status );

[knit-pay]

@knit-pay you should be able to hook into subscription status updates through the status update actions.

Thanks