New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand type definition for filename #1849

Merged

jonathanslenders merged 2 commits into prompt-toolkit:master from alexrudd2:master

Feb 12, 2024

Contributor

alexrudd2 commented Feb 11, 2024

FileHistory.filename is currently hinted as str.

It is used by open() and os.path.exists(). os.path.exists() supports os.PathLike since 3.6

Therefore, the type hint should be expanded to Union[str, os.PathLike].

alexrudd2 added 2 commits

February 11, 2024 14:22


          Expand type definition for filename

8df3b5b


          typo

eda1560

Member

jonathanslenders commented Feb 12, 2024

Thanks!

jonathanslenders merged commit fe38e71 into prompt-toolkit:master

1 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet