Add additional text styles (dim, overline, double underline, curvy underline, blink, & blink fast) #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Before merging this it is also important to benchmark the performance impact on various platforms. Both CPU and memory. This data structure is initialized many times, and it would be a shame to merge this if it significantly impacts the performance on various systems, for a feature that's only available in a few terminals. |
|
Man I reeeeally want this... "dim" support especially. Sigh. Would this make |
joouha
force-pushed
the
extra-style-attributes
branch
from
0d40b91
to
796470d
Compare
joouha
force-pushed
the
extra-style-attributes
branch
from
796470d
to
0795e9f
Compare
- Dim - Overline - Double underline - Curvy underline - Blink - Blink fast
joouha
force-pushed
the
extra-style-attributes
branch
from
0795e9f
to
030ce8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements additional text styles:
Screenshot