Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for docker image pull secret in promitor-agent-resource-discovery #128

Merged
merged 1 commit into from
Sep 30, 2022
Merged

feat: add support for docker image pull secret in promitor-agent-resource-discovery #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions promitor-agent-resource-discovery/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ their default values.
| `image.repository` | Repository which provides the image | `containers.promitor.io/tomkerkhove/promitor-agent-resource-discovery` |
| `image.tag` | Tag of image to use | None, chart app version is used by default |
| `image.pullPolicy` | Policy to pull image | `Always` |
| `image.pullSecrets` | ImagePullSecrets for the pod | `[]` |
| `azureLandscape.cloud` | Azure Cloud to discover resources in. Options are `Global` (default), `China`, `UsGov` & `Germany` | `Global` |
| `azureLandscape.tenantId` | Id of Azure tenant to discover resources in | |
| `azureLandscape.subscriptions` | List of Azure subscription ids to discover resources in | `[]` |
Expand Down
4 changes: 4 additions & 0 deletions promitor-agent-resource-discovery/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ spec:
{{- if .Values.rbac.create }}
serviceAccountName: {{ template "promitor-agent-resource-discovery.serviceaccountname" . }}
{{- end }}
{{- with .Values.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.nodeSelector }}
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 }}
Expand Down
1 change: 1 addition & 0 deletions promitor-agent-resource-discovery/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ fullnameOverride: ""
image:
repository: containers.promitor.io/tomkerkhove/promitor-agent-resource-discovery
pullPolicy: Always
pullSecrets: []
tag:

azureAuthentication:
Expand Down